Additional parsers spec. #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoderer
reviewed
Feb 19, 2018
conf/parsers_openstack.conf
Outdated
|
|
||
| [PARSER] | ||
| # https://rubular.com/r/IvZVElTgNl | ||
| Name ceph |
There was a problem hiding this comment.
Since Ceph is a different product - should we keep it in a separate file?
|
Nice approach! This might be a good way to accomplish #510 as multiline parsers. |
9af7477
to
49cebab
Compare
|
thanks @epcim ! |
rawahars
pushed a commit
to rawahars/fluent-bit
that referenced
this pull request
Oct 24, 2022
Signed-off-by: Huweicai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not sure whether to contribute to parsers.conf directly but finally I follow the current practice add additional files that are not enabled by default.
Default parsers enabled has a reasoning if they are really general, thus format/time match most of the platforms.
Log_time regex, as well as some other parts, could be written better, but instead of expensive re-do I am keeping this for others to update as needed.