Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signv4: remove duplicate assignment #2444

Merged
merged 1 commit into from
Aug 10, 2020
Merged

signv4: remove duplicate assignment #2444

merged 1 commit into from
Aug 10, 2020

Conversation

l2dy
Copy link
Contributor

@l2dy l2dy commented Aug 10, 2020

fluent-bit/src/flb_signv4.c

Lines 970 to 984 in 4b9ac8c

header_value = tmp;
len = flb_sds_len(header_value);
ret = flb_http_add_header(c, "Authorization", 13, header_value, len);
if (ret == -1) {
flb_error("[signv4] could not add authorization header");
flb_sds_destroy(header_value);
return NULL;
}
header_value = tmp;
/* Return the composed final header for testing if required */
return header_value;
}


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

Documentation

  • Documentation required for this feature

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@edsiper edsiper merged commit 7aa03d2 into fluent:master Aug 10, 2020
@edsiper
Copy link
Member

edsiper commented Aug 10, 2020

thanks

edsiper pushed a commit that referenced this pull request Aug 10, 2020
@l2dy l2dy deleted the signv4 branch August 11, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants