core/upstream: flb_upstream_conn.ka_count should be initialized #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flb_upstream_conn.ka_count is not initialized and can get random values. This can break out_forward when it get wrong information that tells that connection is reused, but it's not and out_forward thinks that handshake is already done. Signed-off-by: Jukka Pihl <[email protected]>
|
thanks |
edsiper
pushed a commit
that referenced
this pull request
Dec 16, 2019
flb_upstream_conn.ka_count is not initialized and can get random values. This can break out_forward when it get wrong information that tells that connection is reused, but it's not and out_forward thinks that handshake is already done. Signed-off-by: Jukka Pihl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flb_upstream_conn.ka_count is not initialized and can get
random values.
This can break out_forward when it get wrong information
that tells that connection is reused, but it's not and
out_forward thinks that handshake is already done.
flb_calloc could also be used to zero init whole flb_upstream_conn
in allocation.
Signed-off-by: Jukka Pihl [email protected]