-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in_stdin, out_stdout: Simple non-JSON test causes crash #650
Comments
edsiper
added a commit
that referenced
this issue
Jul 3, 2018
Signed-off-by: Eduardo Silva <[email protected]>
thanks for reporting this issue. I've pushed the fix 2a4d62b which allows to detect the content type and pack as raw text if is not a valid JSON (it should be merged shortly in GIT master) |
edsiper
added a commit
that referenced
this issue
Jul 14, 2018
Signed-off-by: Eduardo Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A simple test like this might be one of the first things a new user tries, but it causes a crash:
This is probably because in_stdin expects JSON. I think this should not crash because it will not leave a good first impression. I'm not sure what the best solution is, maybe it should print a warning once if we get invalid JSON?
Actual output:
In general, I wonder if there should be some more asserts for msgpack types. Here it crashes because it expects an array but it gets a number.
The text was updated successfully, but these errors were encountered: