chore: Upload nox binaries to s3 #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folex
reviewed
Jul 2, 2024
| - name: Upload nox binary to s3 | ||
| uses: osiegmar/s3-publisher-action@v1 | ||
| with: | ||
| bucket: fluence-artifacts |
There was a problem hiding this comment.
Let's use a less generic bucket? Like nox-releases or nox-distribution or fluence-provider-distribution.
So that eg all CCP binaries and all Nox binaries are clearly laid out without any noise around.
There was a problem hiding this comment.
It is not only for nox but for all artifacts we have/we can have. Creating and configuring a bucket for each distribution adds a lot of code.
There was a problem hiding this comment.
We have like just two S3 distributions: CLI and Nox+CCP.
It's benefical to keep things organised. Can change permissions there, easier to review and so on. Less noise, less brain power needed to manage it.
folex
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.