fix tests

florenthub · Feb 2, 2022 · cf174a0 · cf174a0
1 parent 783989d
commit cf174a0
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 19 deletions.
diff --git a/ui-authentication/src/main/java/com/praxis/feat/authentication/vm/AuthVM.kt b/ui-authentication/src/main/java/com/praxis/feat/authentication/vm/AuthVM.kt
@@ -11,6 +11,7 @@ import com.praxis.feat.authentication.R
 import com.praxis.feat.authentication.ui.exceptions.FormValidationFailed
 import com.praxis.feat.authentication.ui.model.LoginForm
 import dagger.hilt.android.lifecycle.HiltViewModel
+import kotlinx.coroutines.CoroutineExceptionHandler
 import kotlinx.coroutines.delay
 import kotlinx.coroutines.flow.*
 import kotlinx.coroutines.launch
@@ -30,6 +31,13 @@ class AuthVM @Inject constructor(
  var uiState = MutableStateFlow<UiState>(UiState.Empty)
  private set
 
+ private val exceptionHandler = CoroutineExceptionHandler { context, throwable ->
+ if (throwable is FormValidationFailed) {
+ snackBarState.value = throwable.failType.message
+ }
+ uiState.value = UiState.ErrorState(throwable)
+ }
+
  init {
  observePasswordReset()
  }
@@ -47,18 +55,12 @@ class AuthVM @Inject constructor(
 
  fun loginNow() {
  uiState.value = UiState.LoadingState
- try {
+
+ viewModelScope.launch(exceptionHandler) {
  credentials.value.validate()
  snackBarState.value = ""
  uiState.value = UiState.SuccessState("sdff")
-
- viewModelScope.launch {
- delay(1500)
- fragmentNavGraphNavigator.navigateFragment(R.id.action_authFragment_to_viewPagerFragment)
- }
- } catch (ex: FormValidationFailed) {
- snackBarState.value = ex.failType.message
- uiState.value = UiState.ErrorState(ex)
+ fragmentNavGraphNavigator.navigateFragment(R.id.action_authFragment_to_viewPagerFragment)
  }
  }
 

diff --git a/ui-authentication/src/test/java/com/praxis/feat/authentication/vm/AuthVMTest.kt b/ui-authentication/src/test/java/com/praxis/feat/authentication/vm/AuthVMTest.kt
@@ -21,16 +21,18 @@ class AuthVMTest {
 
  @MockK
  lateinit var navigator: ComposeNavigator
+
  @MockK
  lateinit var fragmentNavigator: FragmentNavGraphNavigator
+
  @MockK
  private lateinit var savedStateHandle: SavedStateHandle
 
  private lateinit var authVM: AuthVM
 
  @Before
  fun setUp() {
- MockKAnnotations.init(this,  true)
+ MockKAnnotations.init(this, true)
  Dispatchers.setMain(StandardTestDispatcher())
  }
 
@@ -53,12 +55,10 @@ class AuthVMTest {
 
  authVM = AuthVM(savedStateHandle, fragmentNavigator, navigator)
 
-
  authVM.uiState.test {
  assert(awaitItem() is AuthVM.UiState.Empty)
- }
- authVM.loginNow()
- authVM.uiState.test {
+ authVM.loginNow()
+ assert(awaitItem() is AuthVM.UiState.LoadingState)
  assert(awaitItem() is AuthVM.UiState.ErrorState)
  }
  }
@@ -86,11 +86,8 @@ class AuthVMTest {
 
  authVM.uiState.test {
  assert(awaitItem() is AuthVM.UiState.Empty)
- }
-
- authVM.loginNow()
-
- authVM.uiState.test {
+ authVM.loginNow()
+ assert(awaitItem() is AuthVM.UiState.LoadingState)
  assert(awaitItem() is AuthVM.UiState.SuccessState)
  }
  }