fix(FloatingFocusManager): return focus to next tabbable after reference element #3355
atomiksci.yml
on: pull_request
Linting and type checking
59s
Unit tests
1m 21s
Functional tests
5m 34s
Annotations
13 errors and 5 warnings
|
Linting and type checking
@floating-ui/utils#typecheck: command (/home/runner/work/floating-ui/floating-ui/packages/utils) /home/runner/setup-pnpm/node_modules/.bin/pnpm run typecheck exited (2)
|
|
Linting and type checking
Duplicate identifier 'toHaveClass'.
|
|
Linting and type checking
Duplicate identifier 'toHaveClass'.
|
|
Linting and type checking
Subsequent property declarations must have the same type. Property 'toHaveClass' must be of type '(expected: any, ...rest: string[]) => MatcherReturnType', but here has type '(expected: any, className: string, options?: { exact: boolean; } | undefined) => MatcherReturnType'.
|
|
Linting and type checking
Process completed with exit code 2.
|
|
Unit tests
@floating-ui/react#test: command (/home/runner/work/floating-ui/floating-ui/packages/react) /home/runner/setup-pnpm/node_modules/.bin/pnpm run test exited (1)
|
|
Unhandled error:
packages/react/src/components/FloatingFocusManager.tsx#L337
TypeError: relatedTarget?.hasAttribute is not a function
❯ ../../src/components/FloatingFocusManager.tsx:337:26
❯ AsyncResource.runInAsyncScope ../../node:async_hooks:203:9
This error originated in "useDismiss.test.tsx" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "true". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
|
|
useFocus.test.tsx > stays open when focus moves to tooltip rendered inside a shadow root:
packages/react/test/unit/useFocus.test.tsx#L99
TestingLibraryElementError: Unable to find an accessible element with the role "tooltip"
Here are the accessible roles:
button:
Name "":
<button />
--------------------------------------------------
Ignored nodes: comments, script, style
<div>
<button>
<span
data-testid="inside-reference"
tabindex="0"
/>
</button>
</div>
❯ Object.getElementError ../../../../node_modules/.pnpm/@testing-library[email protected]/node_modules/@testing-library/dom/dist/config.js:37:19
❯ ../../../../node_modules/.pnpm/@testing-library[email protected]/node_modules/@testing-library/dom/dist/query-helpers.js:76:38
❯ ../../../../node_modules/.pnpm/@testing-library[email protected]/node_modules/@testing-library/dom/dist/query-helpers.js:52:17
❯ ../../../../node_modules/.pnpm/@testing-library[email protected]/node_modules/@testing-library/dom/dist/query-helpers.js:95:19
❯ useFocus.test.tsx:99:24
|
|
useFocus.test.tsx > stays open when focus moves to element inside reference that is rendered inside a shadow root:
packages/react/test/unit/useFocus.test.tsx#L136
TestingLibraryElementError: Unable to find an accessible element with the role "tooltip"
Here are the accessible roles:
button:
Name "":
<button />
--------------------------------------------------
Ignored nodes: comments, script, style
<div>
<button>
<span
data-testid="inside-reference"
tabindex="0"
/>
</button>
</div>
❯ Object.getElementError ../../../../node_modules/.pnpm/@testing-library[email protected]/node_modules/@testing-library/dom/dist/config.js:37:19
❯ ../../../../node_modules/.pnpm/@testing-library[email protected]/node_modules/@testing-library/dom/dist/query-helpers.js:76:38
❯ ../../../../node_modules/.pnpm/@testing-library[email protected]/node_modules/@testing-library/dom/dist/query-helpers.js:52:17
❯ ../../../../node_modules/.pnpm/@testing-library[email protected]/node_modules/@testing-library/dom/dist/query-helpers.js:95:19
❯ useFocus.test.tsx:136:15
|
|
useFocus.test.tsx > blurs when hitting an "inside" focus guard:
packages/react/test/unit/useFocus.test.tsx#L215
Error: expect(received).toBeInTheDocument()
received value must be an HTMLElement or an SVGElement.
❯ useFocus.test.tsx:215:41
|
|
Unit tests
Process completed with exit code 1.
|
|
Functional tests
@floating-ui/dom#playwright: command (/home/runner/work/floating-ui/floating-ui/packages/dom) /home/runner/setup-pnpm/node_modules/.bin/pnpm run playwright exited (1)
|
|
Functional tests
Process completed with exit code 1.
|
|
Linting and type checking
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, pnpm/action-setup@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Unit tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, pnpm/action-setup@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Functional tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, pnpm/action-setup@v2, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Functional tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "visual-snapshots-diff".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
visual-snapshots-diff
|
54.2 KB |
|