Clean up some bugs in the callback handling #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases if you open and close a connection fast enough, synchronously, the close can happen before the callback gets through the zookeeper event queue and the Tcl event queue. This fix handles both ends of the problem:
Don't set up the callback if you're performing the init synchronously. The previous code put an event on the queue and exited the event handler early if there was no callback routine. This passes null as the event handler for zookeeper_init if there's no callback.
Don't zap the magic number in the zookeeper object until after calling zookeeper_close, because its cleanup may fire any pending handlers.