fix a crash in "create" when the node already exists

flightaware · Jan 13, 2017 · 26053a5 · 26053a5
1 parent 890f76e
commit 26053a5
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/generic/zookeepertcl.c b/generic/zookeepertcl.c
@@ -1835,11 +1835,17 @@ zootcl_create_subcommand(Tcl_Interp *interp, int objc, Tcl_Obj *CONST objv[], ZO
  zootcl_syncCallbackContext *zsc = (zootcl_syncCallbackContext *)ckalloc (sizeof (zootcl_syncCallbackContext));
  zsc->zo = zo;
  zsc->syncDone = 0;
+
  status = zoo_acreate (zh, path, value, valueLen, &ZOO_OPEN_ACL_UNSAFE, flags, zootcl_sync_string_completion_callback, zsc);
+ if (status != ZOK) {
+ ckfree (zsc);
+ return zootcl_set_tcl_return_code (interp, status);
+ }
  if (zootcl_wait (zo, zsc) == TCL_ERROR) {
  ckfree (zsc);
  return TCL_ERROR;
  }
+ status = zsc->rc;
  if (status == ZOK) {
  Tcl_SetObjResult (interp, zsc->dataObj);
  }