Unify 1090 and 978 SkyAware maps - WIP #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectory one level up so we can read from both dump1090-fa/skyaware directories
…story json files in series
rawestmoreland
approved these changes
Jan 18, 2021
mutability
requested changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently dump1090-fa and skyaware978 writes aircraft.json files to separate directories (/run/dump1090-fa/ and /run/skyaware978/). There are separate instances of SkyAware html/js code that consumes them and are 90% identical.
This PR includes the foundational plumbing to merge them together into one map.
Some key changes:
/run/to be able to consume from both dump1090-fa and skyaware978 directories. New map url will be<IP>/skyaware/