Fix 'See Photos' link for hyphenated registrations #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\W would probably work for the regex, but I wanted to make it as narrow as possible.
|
Thanks! I was hoping to get this fixed on the server side but that hasn't happened yet. Fixing it on the client side works well enough though. |
|
I changed my mind about which branch this should go on, so you may see a little weirdness in the github history. |
kpetrilli
pushed a commit
to kpetrilli/dump1090
that referenced
this pull request
Sep 15, 2020
Fix 'See Photos' link for hyphenated registrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the 'See Photos' link for hyphenated registrations, which is currently broken. \W would probably work for the regex, but I wanted to make it as narrow as possible.