Added support for HackRF One #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… along with the rest of the project.
|
I tested this and it works! |
mutability
reviewed
Aug 3, 2020
Comment on lines
+131
to
+185
| status = hackrf_init(); | ||
| if (status != 0) { | ||
| fprintf(stderr, "HackRF: hackrf_init failed with code %d", status); | ||
| hackrf_close(HackRF.device); | ||
| hackrf_exit(); | ||
| return false; | ||
| } | ||
|
|
||
| status = hackrf_open(&HackRF.device); | ||
| if (status != 0) { | ||
| fprintf(stderr, "HackRF: hackrf_open failed with code %d", status); | ||
| hackrf_close(HackRF.device); | ||
| hackrf_exit(); | ||
| return false; | ||
| } | ||
|
|
||
| status = hackrf_set_freq(HackRF.device, HackRF.freq); | ||
| if (status != 0) { | ||
| fprintf(stderr, "HackRF: hackrf_set_freq failed with code %d", status); | ||
| hackrf_close(HackRF.device); | ||
| hackrf_exit(); | ||
| return false; | ||
| } | ||
|
|
||
| status = hackrf_set_sample_rate(HackRF.device, HackRF.rate); | ||
| if (status != 0) { | ||
| fprintf(stderr, "HackRF: hackrf_set_sample_rate failed with code %d", status); | ||
| hackrf_close(HackRF.device); | ||
| hackrf_exit(); | ||
| return false; | ||
| } | ||
|
|
||
| status = hackrf_set_amp_enable(HackRF.device, HackRF.enable_amp); | ||
| if (status != 0) { | ||
| fprintf(stderr, "HackRF: hackrf_set_amp_enable failed with code %d", status); | ||
| hackrf_close(HackRF.device); | ||
| hackrf_exit(); | ||
| return false; | ||
| } | ||
|
|
||
| status = hackrf_set_lna_gain(HackRF.device, HackRF.lna_gain); | ||
| if (status != 0) { | ||
| fprintf(stderr, "HackRF: hackrf_set_lna_gain failed with code %d", status); | ||
| hackrf_close(HackRF.device); | ||
| hackrf_exit(); | ||
| return false; | ||
| } | ||
|
|
||
| status = hackrf_set_vga_gain(HackRF.device, HackRF.vga_gain); | ||
| if (status != 0) { | ||
| fprintf(stderr, "HackRF: hackrf_set_vga_gain failed with code %d", status); | ||
| hackrf_close(HackRF.device); | ||
| hackrf_exit(); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Missing trailing \n on these error messages
|
|
||
| struct timespec thread_cpu; | ||
|
|
||
| int handle_hackrf_samples(hackrf_transfer *transfer) |
There was a problem hiding this comment.
This needs to become static now that we're building with -Wmissing-declarations (that change postdates your PR)
mutability
reviewed
Aug 3, 2020
Comment on lines
+131
to
+145
| status = hackrf_init(); | ||
| if (status != 0) { | ||
| fprintf(stderr, "HackRF: hackrf_init failed with code %d", status); | ||
| hackrf_close(HackRF.device); | ||
| hackrf_exit(); | ||
| return false; | ||
| } | ||
|
|
||
| status = hackrf_open(&HackRF.device); | ||
| if (status != 0) { | ||
| fprintf(stderr, "HackRF: hackrf_open failed with code %d", status); | ||
| hackrf_close(HackRF.device); | ||
| hackrf_exit(); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
If I understand the hackrf API correctly, the cleanup paths here need to be a little more careful (don't call exit if init failed; don't call close if open failed)
mutability
added a commit
that referenced
this pull request
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support for HackRF One device using libhackrf. I tested all the new functions successfully for a few days.