SkyView: Fix aircraft trail handling #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make aircraft trail handling more consistent and the code hopefully easier to understand. Fix position comparison (comparing array references does not work). When initially loading the SkyView webpage, there are sometimes gaps in the aircraft trails when the trail transitions from estimated/dotted to known/solid track. Fix elastic band style to handle estimated segments properly.
5d475be
to
c7fccf2
Compare
When loading the history, the check for stale aircraft tracks is done differently. This results in lots of dotted/stale track after opening the web page. Improve this by using the same 5 second timeout stale criterion to postions loaded from history. Add an additional check to better detect stale tracks when loading history positions that are spaced 30 seconds apart.
c7fccf2
to
207ca0c
Compare
|
Removed the altitude change commit because it could cause problems when the altitude was undefined. If you don't like the force-pushes in here, please just say so and i can reopen a new PR. |
|
I walked through the new logic and it looks good to me. Thanks for looking at this. |
kpetrilli
pushed a commit
to kpetrilli/dump1090
that referenced
this pull request
Sep 15, 2020
SkyView: Fix aircraft trail handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in the screenshot below, aircraft trails in SkyView sometimes have gaps when an estimated segment ends.
This PR fixes that problem and makes the updateTrack function consistent/logical and hopefully easier to understand.
After the change only the previous position is appended following the logic of that function, the current position is drawn only with the elastic band feature.
The number of line segments in memory is significantly reduced by both commits, this improves responiveness when using the "Show All Tracks" function.