Overflow fix #40
Merged
Overflow fix #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to commit 45886ed faup1090: write _v on every line, bump TSV_VERSION and maybe other changes the TSV packets are bigger and some users have reported the following error: piaware[9040]: faup1090(27427): fatsv: output too large (max 600, overran by 20) Fix this error by increasing TSV_MAX_PACKET_SIZE to 800
If the \n termination of TSV messages is missing, faup1090 encounters
the following error:
Caught background error: list must have an even number of elements
while executing
"array set row [split $line "\t"]"
(object "::faup1090" method "::FaupConnection::data_available" body line 28)
This missing termination with \n can happen when p == end is true in the
overrun check. vsnprintf will always terminate the string with \0, so if
the vsnprintf is called to write the to the last position in the buffer
(end-1), it will write \0 instead to terminate the string as not to
overflow the buffer.
To catch that possibility the overrun check is changed to p < end as
then vsnprintf is assured to have had enough room to write the \0
termination to end-1.
|
Thanks @wiedehopf ! |
kpetrilli
pushed a commit
to kpetrilli/dump1090
that referenced
this pull request
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some errors with piaware reported by users here:
https://discussions.flightaware.com/t/announcing-piaware-3-latest-version-3-6-3/18829/959?u=wiedehopf
The first commit should in most practical situations fix both errors as the overrun should no longer happen.
The second commit is just to ensure that should the TSV packet for some reason grow further no crashes are caused by an overrun.