Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portability fixes #38

Merged
merged 4 commits into from
Aug 7, 2020
Merged

Portability fixes #38

merged 4 commits into from
Aug 7, 2020

Conversation

mikenor
Copy link

@mikenor mikenor commented Mar 31, 2019

Fixes building on MacOS (and probably OpenBSD but untested). Commit bef563b had removed the building of cross-platform compatibility code that exists in the compat/ folder.

Tested on MacOS 10.14/Mojave, OS X 10.11/El Capitan, and Debian 9/Stretch.

Building with BladeRF would not work for me on Mac, so build using make BLADERF=no, at least for now.

Re-implements platform-specific build of compatibility functions. Had been removed by bef563b.
Newish version of MacOS's time.h already `typedef`s `clockid_t` but doesn't seem to `#define` anything indicating such; as a workaround assume that `#ifdef CLOCK_MONOTONIC` on a Mac means that `clockid_t` has been `typedef`'d.
FreeBSD support, reworked from earlier pr by @neveragainde
@mikenor
Copy link
Author

mikenor commented Apr 1, 2019

Also stole the FreeBSD additions from PR #33 and incorporated them into this. Have not actually tested on FreeBSD though. Oh and I changed it so BLADERF=no is the default on non-Linux.

@mutability mutability changed the base branch from master to dev August 7, 2020 06:03
mutability added a commit that referenced this pull request Aug 7, 2020
This is minimally tested on OSX, and not at all on *BSD.
Since I did some cleanups in the compat code without testing on *BSD,
it could well be broken there.

This may also fix #33 as #38 included those changes.
@mutability mutability merged commit 1174841 into flightaware:dev Aug 7, 2020
@mutability
Copy link

Current dev branch builds OK for me on Mojave, and seems to be able to talk to a rtlsdr OK. hackrf & bladerf support also appear to build OK if you install the corresponding libraries. Can you try it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants