Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style.css hide scroll bar when not needed #26

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Update style.css hide scroll bar when not needed #26

merged 2 commits into from
Dec 11, 2019

Conversation

Gaz492
Copy link

@Gaz492 Gaz492 commented Oct 3, 2018

Set overflow to auto in #sidebar_canvas

@mutability mutability added the web Stuff for the web team to look at label Mar 4, 2019
Copy link

@thornjad thornjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately some spacing got mixed up with mixed spaces and tabs, but since the fork/branch this PR is coming from no longer exists, we can't make changes now. Since it's stylistic and not functional, in this case I'm going to be fine with it.

In terms of actual functional change, overflow: auto is the correct usage here, thanks for that change! And also good catch on the double semi-colon! That can trip up older browsers.

@thornjad thornjad changed the base branch from master to dev December 11, 2019 15:53
@thornjad thornjad merged commit 404ac5d into flightaware:dev Dec 11, 2019
@HNJAMeindersma
Copy link

OMG YES! I've done this myself after installation. Might as well change this in the repo, since the overflow: scroll; option as a default does not make any sense. Yeah ok; it's to have when the table constantly changes between ending right before and after the bottom of your viewport. But it think this not the case for many user in an average receiver location.

kpetrilli pushed a commit to kpetrilli/dump1090 that referenced this pull request Sep 15, 2020
Update style.css hide scroll bar when not needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web Stuff for the web team to look at
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants