Update skyview with extended mode S data fields #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
July 30, 2018 17:51
* Add extended Mode-S info to infoblock * Move the infoblock to the sidebar * Resizable infoblock * Add hover tooltips for infoblock labels
mutability
requested changes
Aug 17, 2018
public_html/formatter.js
Outdated
| @@ -156,6 +168,16 @@ function format_distance_long(dist, displayUnits, fixed) { | |||
| return dist_text; | |||
| } | |||
|
|
|||
| function format_distace_short (dist, displayUnits) { | |||
public_html/formatter.js
Outdated
| // converts meters to feet or just returns meters | ||
| function convert_distance_short(dist, displayUnits) { | ||
| if (displayUnits === "imperial") { | ||
| return (dist * 3.28084); // meters to feet |
There was a problem hiding this comment.
Prefer dist / 0.3048 which is exact.
public_html/planeObject.js
Outdated
| @@ -28,7 +28,14 @@ function PlaneObject(icao) { | |||
| this.nav_altitude = null; | |||
| this.nav_heading = null; | |||
| this.nav_modes = null; | |||
| this.nav_qnh = null; | |||
| this.nav_qnh = null; | |||
There was a problem hiding this comment.
I know the tab/space stuff is all over the place in this code, but can we keep it to spaces here to be consistent with the surrounding stuff?
public_html/style.css
Outdated
| @@ -471,12 +508,12 @@ select.error, textarea.error, input.error { | |||
|
|
|||
| .infoRowTitle { | |||
| display: inline-block; | |||
| width: 50%; | |||
| /* width: 50%; */ | |||
public_html/style.css
Outdated
| } | ||
|
|
||
| .infoRowContent { | ||
| display: inline-block; | ||
| width: 40%; | ||
| /* width: 40%; */ |
public_html/style.css
Outdated
| @@ -517,7 +561,7 @@ select.error, textarea.error, input.error { | |||
| .lightGreyBackground { | |||
| background-color: #efefef; | |||
| } | |||
|
|
|||
| /* | |||
|
Cleaned up css/spacing and typo. |
mutability
approved these changes
Aug 17, 2018
kpetrilli
pushed a commit
to kpetrilli/dump1090
that referenced
this pull request
Sep 15, 2020
Update skyview with extended mode S data fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.