Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused crc-check option on dump1090 and faup1090 #201

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Remove unused crc-check option on dump1090 and faup1090 #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e690a8f
Remove unused crc-check option on dump1090 and faup1090
nunojpg Sep 30, 2022
8f994f9
Still accept --no-crc-check option (but ignore/warn about it)
mutability Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions dump1090.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ static void modesInitConfig(void) {
// Now initialise things that should not be 0/NULL to their defaults
Modes.gain = MODES_DEFAULT_GAIN;
Modes.freq = MODES_DEFAULT_FREQ;
Modes.check_crc = 1;
Modes.fix_df = 1;
Modes.interactive_display_ttl = MODES_INTERACTIVE_DISPLAY_TTL;
Modes.json_interval = 1000;
Expand Down Expand Up @@ -349,7 +348,6 @@ static void showHelp(void)
"--no-fix Disable error correction using CRC\n"
"--no-fix-df Disable error correction of the DF message field\n"
" (reduces CPU requirements)\n"
"--no-crc-check Disable messages with broken CRC (discouraged)\n"
"--enable-df24 Enable decoding of DF24 Comm-D ELM messages\n"
"--lat <latitude> Reference/receiver latitude for surface positions\n"
"--lon <longitude> Reference/receiver longitude for surface positions\n"
Expand Down Expand Up @@ -631,7 +629,7 @@ int main(int argc, char **argv) {
} else if (!strcmp(argv[j],"--no-fix-df")) {
Modes.fix_df = 0;
} else if (!strcmp(argv[j],"--no-crc-check")) {
Modes.check_crc = 0;
fprintf(stderr, "warning: --no-crc-check no longer supported, option ignored (please raise an issue on github if you have a usecase that needs this)\n");
} else if (!strcmp(argv[j],"--phase-enhance")) {
// Ignored, always enabled
} else if (!strcmp(argv[j],"--raw")) {
Expand Down
1 change: 0 additions & 1 deletion faup1090.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ static void faupInitConfig(void) {

// Now initialise things that should not be 0/NULL to their defaults
Modes.nfix_crc = 1;
Modes.check_crc = 1;
Modes.fix_df = 1;
Modes.net = 1;
Modes.net_heartbeat_interval = MODES_NET_HEARTBEAT_INTERVAL;
Expand Down