Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract SkyAware Anywhere from fa_web #188

Merged
merged 11 commits into from
Jul 13, 2022
Merged

Conversation

PaulKuruvila
Copy link

@PaulKuruvila PaulKuruvila commented Jun 27, 2022

Additional Comments/Things to Consider BEFORE merging:

  • The preexisting status.json file in fa_web has only been deleted locally
  • Currently, the changes to flightaware.com.config have only been made locally in my vhost:
    Static status JSON RewriteRule ^/status.json /ajax/skyaware/status.json [L,QSA]
    =>
    Static status JSON RewriteRule ^/status.json /skyaware/status.json [L,QSA]
  • I will make a PR in fa_web for these changes*

*since these changes will be a part of the cleanup process and should not affect the functionality of the current changes, the PR will be made later

Jira links:

https://flightaware.atlassian.net/browse/WEB-17586
https://flightaware.atlassian.net/browse/WEB-17587
https://flightaware.atlassian.net/browse/WEB-17588

@PaulKuruvila PaulKuruvila merged commit 59eb162 into abstract_data Jul 13, 2022
@PaulKuruvila PaulKuruvila deleted the skyaware_logo branch July 13, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants