Make ICAO type DB requests wait until the file is loaded #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge latest dev branch
This will stop multiple requests and responses for the icao_aircraft_types.json file.
|
The way that the main db loader handles this is to stack up all requests on the same deferrable, might be simpler to do the same here. |
|
This is old and almost certainly out of date, and there's a better way to implement it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the icao_aircraft_types.json file was being loaded multiple times because a few AJAX requests fired off to get the file before it had loaded. This change waits until the file has loaded before running all the queued up requests against it.
It's probably not the best implementation but was the best I could come up with with my limited JS skills!