Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsp: Remove generated starch code from source control #152

Closed
wants to merge 1 commit into from

Conversation

gtjoseph
Copy link

@gtjoseph gtjoseph commented Sep 3, 2021

It's tough to rebase if two people regenerate the code in
dsp/generated and commit it.

  • Removed dsp/generated from source control
  • Added dsp/generated to .gitignore
  • Modified dsp/starchgen.py to automatically create
    dsp/generated if it doesn't exist.
  • Updated Makefile to automatically run starchgen.py if
    dsp/generated/makefile.$(STARCH_MIX) is missing or out
    of date with respect to starchgen.py.

It's tough to rebase if two people regenerate the code in
dsp/generated and commit it.

 * Removed dsp/generated from source control
 * Added dsp/generated to .gitignore
 * Modified dsp/starchgen.py to automatically create
   dsp/generated if it doesn't exist.
 * Updated Makefile to automatically run starchgen.py if
   dsp/generated/makefile.$(STARCH_MIX) is missing or out
   of date with respect to starchgen.py.
@mutability
Copy link

Part of the original design philosophies of starch was "zero build-time code generation", so regenerating on build fundamentally breaks that and means there's extra build-time dependencies (python3 and mako) - which is going to break a whole lot of downstream build scripts.

But I do appreciate the difficulty it causes for developers working with the starch code. (Which is currently a set of .. two?)

Do you have another approach that avoids the extra dependencies for a simple "I checked the code out of github and tried to build it" build.

@gtjoseph
Copy link
Author

gtjoseph commented Sep 4, 2021

But I do appreciate the difficulty it causes for developers working with the starch code. (Which is currently a set of .. two?)

Heh, yeah I know. :)

Do you have another approach that avoids the extra dependencies for a simple "I checked the code out of github and tried to build it" build.

None that wouldn't make more work for us. No worries. I was just a bit annoyed when I did a rebase yesterday and all of the generated files had conflicts. I'm over it now. :)

@gtjoseph gtjoseph closed this Sep 4, 2021
@mutability
Copy link

No worries. If you do find something that makes things easier here while keeping the build simple, let me know your ideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants