DH8 icon

[daviessm]

Update DH8 family icons to large twin turboprop to match FA webview (and reality)

[daviessm]

I noticed that aircraft type icons come from icao_aircraft_types and are overridden in markers.js. Since the former isn't a dump from an upstream source any more, does it make sense to have this maintained in two files? I'd be happy to work on merging them into one if you think it would work better.

[mutability]

I think the dash-8 case is just one case of a more general problem which is that the L2T and L2P icon mappings look like they have been reversed. Asking the skyview developers what the story there is now.

I don't understand your question about icao_aircraft_types. It was mechanically generated and should be kept up to date (I will remind the skyview devs). It maps aircraft type designators (DH8D) to descriptions (L2T). Then markers.js either has a specific rule for the model, or a fallback rule based on the generic description.

[daviessm]

Re: the icao_aircraft_types I could have sworn I saw in the readme file that it wasn't being maintained any more but it looks like I was wrong and that was the hex code DB readme instead.

If the modification is made upstream then the override I put in can probably be removed, along with the original override. Let me know if you want me to make any changes but if not you can close this.

[mutability]

I fixed the L2P/L2T mapping and removed the Dash 8 override.
Will revisit this later, I need to make sure that the mappings stay in sync with the FA maps somehow.