Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Windows support #141

Closed
wants to merge 5 commits into from
Closed

Conversation

snake-4
Copy link

@snake-4 snake-4 commented Jul 27, 2021

  • Added support for Windows platform with instructions in the README file.
  • Made some changes to the starch's python code and templates which were required for the Windows support. I can make a PR - on the starch's repo instead as well for this.
  • Fixed a typo and added the default values in the help text of HackRF's arguments, there are no other changes to any SDR interface code.
  • Added a file for the math constants to minimize the dependency on non-standard C extensions. While there are still non-standard extensions used such as the nanosleep, strdup, they can be changed in the future.

For Windows builds, the required DLL files have to be copied manually to the build folder.
The DLL files required by a dump1090 build with all SDR integration code enabled and compiled with MinGW-w64 10.3 are as follows:
bladeRF.dll hackrf.dll libiconv-2.dll libintl-8.dll libsystre-0.dll libtre-5.dll libwinpthread-1.dll LimeSuite.dll rtlsdr.dll
These files can change depending on the compiler used.

I've tried to modify the CI files for the changed src path but I'm not sure if they work.
Compiles fine on both Ubuntu(GCC 9.3.0) and Windows(MSYS2 MinGW-w64 10.3) without any warnings.

Note: Dependent on #140, the dependency has to be merged first!
Note: Only the last commit in this PR is relevant, the other commits are all from the PR #140 which does not modify any source files.

Makefile and starch template files in order to change the file structure.
changed some size types from int to size_t, fixed HackRF argument help text typo. Also regenerated the starch DSP files using the updated template file to have Windows support in the DSP code.
@mutability
Copy link

I can probably take these individually, if you're willing to break them out into separate PRs

  • starch changes (please PR against the starch repo)
  • hacksdr fixes
  • the math portability stuff

The overall Windows support I probably can't take until at least after the 6.0 release which is coming up soon - it's too close to add something big like that unfortunately.

The dependency on #140 unfortunately means I can't do much with this PR until #140 is resolved one way or another

@snake-4
Copy link
Author

snake-4 commented Jul 27, 2021

Created a PR on the starch repo. Will undo the changes here once that gets merged into the dev branch of this repo.

@snake-4 snake-4 closed this Aug 4, 2021
@snake-4 snake-4 deleted the dev-windows-support branch August 4, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants