Merge pull request #161 from seleb/bug/user-agent

fix: remove disallowed `user-agent` request header
flickr · Oct 9, 2023 · 3b0a0e3 · 3b0a0e3
2 parents 5d7e2cb + 3a3f448
commit 3b0a0e3
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 32 deletions.
diff --git a/lib/request.js b/lib/request.js
@@ -20,9 +20,6 @@ function Request(method, url) {
 
  // keep track of all request params for oauth signing
  this.params = {};
-
- // superagent no longer sets a default user agent header
- this.set('user-agent', 'flickr-sdk/' + version);
 }
 
 Request.prototype = Object.create(request.Request.prototype);

diff --git a/test/request.js b/test/request.js
@@ -13,14 +13,6 @@ describe('lib/request', function () {
  assert(subject('GET', 'https://www.example.com') instanceof Request);
  });
 
- it('has a default user agent', function () {
- const req = subject('GET', 'https://www.example.com');
-
- assert.strictEqual(req.get('user-agent'),
- 'flickr-sdk/' + process.env.npm_package_version
- );
- });
-
  it('supports request(url, callback)', function () {
  var end = sinon.stub(subject.Request.prototype, 'end').returnsThis();
  var spy = sinon.spy();

diff --git a/test/services.feeds.js b/test/services.feeds.js
@@ -18,13 +18,6 @@ describe('services/feeds', function () {
  assert(subject._('photos_public') instanceof Request);
  });
 
- it('adds default request headers', function () {
- const req = subject._('photos_public');
-
- assert.strictEqual(req.get('user-agent'),
- 'flickr-sdk/' + process.env.npm_package_version);
- });
-
  it('uses the correct path', function () {
  var req = subject._('photos_public');
  var url = parse(req.url);

diff --git a/test/services.replace.js b/test/services.replace.js
@@ -34,13 +34,6 @@ describe('services/replace', function () {
  });
  });
 
- it('adds default request headers', function () {
- const req = new Subject(auth, 41234567890);
-
- assert.strictEqual(req.get('user-agent'),
- 'flickr-sdk/' + process.env.npm_package_version);
- });
-
  it('uses the correct method', function () {
  var req = new Subject(auth, 41234567890);
 

diff --git a/test/services.upload.js b/test/services.upload.js
@@ -28,13 +28,6 @@ describe('services/upload', function () {
  });
  });
 
- it('adds default request headers', function () {
- const req = new Subject(auth, 41234567890);
-
- assert.strictEqual(req.get('user-agent'),
- 'flickr-sdk/' + process.env.npm_package_version);
- });
-
  it('uses the correct method', function () {
  var req = new Subject(auth);