Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging duplicate functions in IncMHA, SpecIncMHA, and TreeIncNHA #736

Merged
merged 11 commits into from
May 25, 2023

Conversation

jiazhihao
Copy link
Collaborator

Description of changes:

This PR is an attempt to merge the duplicate functions and code across IncMHA, SpecIncMHA, and TreeIncMHA implementations.

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

Before merging:

  • Did you update the flexflow-third-party repo, if modifying any of the Cmake files, the build configs, or the submodules?

Copy link
Collaborator

@goliaro goliaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This will help us remove the duplicated code. Feel free to merge!

@xinhaoc
Copy link
Collaborator

xinhaoc commented May 23, 2023

on my side the bug is fixed.

@jiazhihao
Copy link
Collaborator Author

@xinhaoc What's the command line you used to run SpecInfer? I am still observing random output tokens using the following command line:

./inference/spec_infer/spec_infer -ll:gpu 4 -ll:fsize 14000 -ll:zsize 30000 -llm-model llama -llm-weight ../inference/weights/llama_190M_weights/ -llm-config ../inference/models/configs/llama_190M.json -ssm-model llama -ssm-weight ../inference/weights/llama_190M_weights/ -ssm-config ../inference/models/configs/llama_190M.json -tokenizer ../inference/tokenizer/tokenizer.model -prompt ../inference/prompt/test.json

@jiazhihao jiazhihao enabled auto-merge (squash) May 24, 2023 16:10
@jiazhihao jiazhihao merged commit 28b31cd into inference May 25, 2023
31 checks passed
@goliaro goliaro deleted the spec_infer_bug_fx branch July 19, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants