Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): timeline viewer display wrong info #157

Merged
merged 11 commits into from
May 17, 2024

Conversation

kobenguyent
Copy link
Collaborator

Screenshot 2024-05-16 at 17 35 04
Screenshot 2024-05-16 at 17 35 52

Copy link

netlify bot commented May 16, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 848c0c1
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/66471a439235660008cdd3fd
😎 Deploy Preview https://deploy-preview-157--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

I think we'll still need to display the response after the response headers.

@flawiddsouza
Copy link
Owner

I think it would look better if the response came after the response headers, as that's how http flows.

@flawiddsouza
Copy link
Owner

Just noticed this. This prop is incorrect:
image

As response is not of type Response. And you'll see this warning in the console from vue:
image

@kobenguyent
Copy link
Collaborator Author

May you advise which type would be better?

@flawiddsouza
Copy link
Owner

May you advise which type would be better?

Since the script is js, the only other prop type you can specify is Object.

@kobenguyent
Copy link
Collaborator Author

Thanks. Updated as proposal.

@flawiddsouza
Copy link
Owner

Add a line break after the response headers, so as to have some separation between headers and body:
image

Also, there seem to be 3 line breaks before the end, 1 should be enough.

@flawiddsouza
Copy link
Owner

Query string is not getting appended to the url end:
image

@flawiddsouza flawiddsouza merged commit 4cbfab6 into flawiddsouza:main May 17, 2024
6 checks passed
@kobenguyent kobenguyent deleted the fix/timeline-viewer branch May 17, 2024 09:34
@flawiddsouza
Copy link
Owner

Hey @kobenguyent, just noticed that timeline doesn't display anything when url has a environment variable:
image
You're most likely using the url inside the request property. It needs to be url property directly in response, as that will have the final resolved url. I'm messaging here because I'm not sure how to reach you otherwise 😅

@kobenguyent
Copy link
Collaborator Author

hey @flawiddsouza oh I wasn't aware of this case. Will take a look! Thanks for your info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants