Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): ResponsePanel > Timeline viewer #155

Merged
merged 10 commits into from
May 16, 2024

Conversation

kobenguyent
Copy link
Collaborator

Screenshot 2024-05-16 at 11 34 27

Copy link

netlify bot commented May 16, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit e7f81c9
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/6646014b97221e00086c0b4a
😎 Deploy Preview https://deploy-preview-155--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

Rename Timeline.vue to ResponsePanelTimeline.vue, so we can easily find it in code.

Add a line break after comma, if other imported items have it
image

Add a space before { and after } here:
image

Check if url package is really necessary. new URL (https://developer.mozilla.org/en-US/docs/Web/API/URL) should actually be enough, as far as I know.
image

@flawiddsouza
Copy link
Owner

image

image

Add a space before { and after } here:
image

I wonder if there's an eslint rule for this.

Also, the reason I recommend adding trailing commas is because it gives better git diffs.

@kobenguyent
Copy link
Collaborator Author

Yeah, wondering the same. If that's the case, better to update the eslint rules then so that we could benefit from it.

@kobenguyent kobenguyent changed the title feat(ui): timeline viewer feat(ui): ResponsePanel > Timeline viewer May 16, 2024
@flawiddsouza
Copy link
Owner

image
Is this change required?

Think this package-lock can be reverted as there's no package change here:

image

@flawiddsouza
Copy link
Owner

flawiddsouza commented May 16, 2024

This feature request has been pending for a while. Thanks for taking care of it.

@flawiddsouza flawiddsouza merged commit f9fecff into flawiddsouza:main May 16, 2024
6 checks passed
@kobenguyent kobenguyent deleted the feat/timeline branch May 16, 2024 13:48
@flawiddsouza
Copy link
Owner

Hey @kobenguyent, just noticed that there's no request body displayed in the timeline. I think you can take this up for the next release.

@kobenguyent
Copy link
Collaborator Author

oh true @flawiddsouza the timeline currently displays the response instead of the request body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants