Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(ui): some improvements on tabs #148

Merged
merged 3 commits into from
May 14, 2024

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented May 14, 2024

  • selected tab is now more noticeable.

Screenshot 2024-05-14 at 11 05 39

Copy link

netlify bot commented May 14, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 675bfb0
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/66436e89c40e1f00083de238
😎 Deploy Preview https://deploy-preview-148--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

Heyo, not sure about this change. The selected tab now draws a lot of attention from our eyes compared to the rest of the application. Maybe a lighter color could work? Not 100% sure though.

@kobenguyent
Copy link
Collaborator Author

I did apply some light color, would be noticeable, I think. But yeah, open to any suggestion.

Current
Screenshot 2024-05-14 at 11 41 23

Changes
Screenshot 2024-05-14 at 11 41 52

@flawiddsouza
Copy link
Owner

flawiddsouza commented May 14, 2024

This looks a bit better. Can you show me how it will look for the dark mode, with a darker color than before?

@kobenguyent
Copy link
Collaborator Author

Dark mode
Before
Screenshot 2024-05-14 at 13 42 54
After
Screenshot 2024-05-14 at 13 43 51

@flawiddsouza
Copy link
Owner

You can push a commit. I'll check how it looks in the deploy preview.

@kobenguyent
Copy link
Collaborator Author

oh, it's already there.

@flawiddsouza
Copy link
Owner

Can you switch to var(--sidebar-item-active-color) instead of the new var(--background-color-lighter)? It's a bit lighter than the new colors. I'll merge it after that. You can remove those css variables as well.

@flawiddsouza
Copy link
Owner

flawiddsouza commented May 14, 2024

Also, just saw this unrelated change:
image
What's the change?

Update:
Just checked and let's revert this. It's a personal preference of mine to not have too much empty space. Compact layouts are preferable.

Before:
image

After:
image

@flawiddsouza
Copy link
Owner

What do you think of this design?
image
image

I really want to keep that seamless tab look:
image

It's there everywhere. On github:
image
In chrome:
image

Don't want to lose that look.

@kobenguyent
Copy link
Collaborator Author

kobenguyent commented May 14, 2024

Screenshot 2024-05-14 at 15 59 30

Screenshot 2024-05-14 at 16 01 28

updated as proposal.

@flawiddsouza flawiddsouza merged commit 0a439a0 into flawiddsouza:main May 14, 2024
6 checks passed
@kobenguyent kobenguyent deleted the ui/some-improvements branch May 14, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants