Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): use pointer cursor #136

Merged
merged 9 commits into from
May 8, 2024

Conversation

kobenguyent
Copy link
Collaborator

Screen.Recording.2024-05-07.at.17.39.11.mov

use pointer cursor where it is clickable.

Copy link

netlify bot commented May 7, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 31e45bc
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/663b362ea2e903000868eddf
😎 Deploy Preview https://deploy-preview-136--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

image
This area is not clickable, so it doesn't make sense to show a pointer when hovering over it. Probably better to add pointer to request-panel-tab class.

@flawiddsouza
Copy link
Owner

Getting mouse pointer when I hover over inputs in the Query tab.
image

Probably due to this:
image

Can you look into a better alternative here, so only clickable items show pointers?

@flawiddsouza
Copy link
Owner

That's good. Now it works for the table in Query tab but not for tables in Body & Headers tab.

Removing the greater than symbol from selector should probably work:
image

@kobenguyent
Copy link
Collaborator Author

That's good. Now it works for the table in Query tab but not for tables in Body & Headers tab.

Removing the greater than symbol from selector should probably work: image

thanks for your review! Unfortunately, it won't work. So I fixed by another approach then.

@flawiddsouza
Copy link
Owner

image
This change seems unrelated. Can you revert it?

@flawiddsouza
Copy link
Owner

Since all select elements now have a pointer, you can remove these rules:
image

image

@kobenguyent
Copy link
Collaborator Author

image This change seems unrelated. Can you revert it?

it was like this on current main branch, so I just changed it back to its original state.

https://github.com/flawiddsouza/Restfox/blob/main/packages/ui/src/components/RequestPanel.vue#L830

@flawiddsouza
Copy link
Owner

it was like this on current main branch, so I just changed it back to its original state.

https://github.com/flawiddsouza/Restfox/blob/main/packages/ui/src/components/RequestPanel.vue#L830

Ah alright. Then no issues. Seems proper.

image

There's one more select rule.

And that should be it.

@flawiddsouza flawiddsouza merged commit 1610d3e into flawiddsouza:main May 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants