Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove content-type with no body request #134

Conversation

kobenguyent
Copy link
Collaborator

  • move MIME type to constants
  • remove content-type header when no body is chosen
no-body-remove-header.mov

Copy link

netlify bot commented May 7, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit a4e7ada
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/663a4c9f3e735b00086b9ed8
😎 Deploy Preview https://deploy-preview-134--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

Thanks for the PR.
image
mimeType = 'No Body' is not required, as null is equal to no body. You can remove that if block. Rest everything looks good.

@kobenguyent
Copy link
Collaborator Author

Thanks for the PR. image mimeType = 'No Body' is not required, as null is equal to no body. You can remove that if block. Rest everything looks good.

fixed!

@flawiddsouza
Copy link
Owner

image
Don't think this check is required, as there's a if block around it checking the same.

@flawiddsouza flawiddsouza merged commit 3d970e2 into flawiddsouza:main May 7, 2024
6 checks passed
@kobenguyent kobenguyent deleted the fix/remove-content-type-no-body-request branch May 7, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants