Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docker): tag new version as latest #117

Merged
merged 3 commits into from
Apr 15, 2024
Merged

ci(docker): tag new version as latest #117

merged 3 commits into from
Apr 15, 2024

Conversation

BoscoDomingo
Copy link
Contributor

This should tag versions as latest as they are created (assuming you never run this for a version that's already been published).

I haven't tested it per se, but the push should include all tags, and since we're building in a completely blank environment, it should only possess the latest Docker image.

See if you can test these commands locally first @flawiddsouza to ensure nothing is pushed that we wouldn't want 🙏🏼

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit af0f28c
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/661d5a55ea1efc0008e8c9f9
😎 Deploy Preview https://deploy-preview-117--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

Looks good. I'll check this when I get some time. Thanks.

@flawiddsouza
Copy link
Owner

Hi @BoscoDomingo,

Looks like this needs to change from:

docker push -a flawiddsouza/restfox:${{ env.VERSION }}

to

docker push -a flawiddsouza/restfox

When I tried your command I got the error

tag can't be used with --all-tags/-a

It seems you shouldn't mention a tag name if pushing all tags.

While we're at it, let's use the full flag name --all-tags instead of the -a short form. As it's more easily understandable for someone who's unfamilar with the -a flag.

@BoscoDomingo
Copy link
Contributor Author

Hi @BoscoDomingo,

Looks like this needs to change from:

docker push -a flawiddsouza/restfox:${{ env.VERSION }}

to

docker push -a flawiddsouza/restfox

When I tried your command I got the error

tag can't be used with --all-tags/-a

It seems you shouldn't mention a tag name if pushing all tags.

While we're at it, let's use the full flag name --all-tags instead of the -a short form. As it's more easily understandable for someone who's unfamilar with the -a flag.

Sounds good to me. Let me get that fixed in a sec

@flawiddsouza flawiddsouza merged commit c8798d4 into flawiddsouza:main Apr 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants