New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't define HTML5::Document and HTML5::DocumentFragment if HTML5 isn't supported #265

Merged

flavorjones merged 2 commits into main from flavorjones-test-with-old-nokogiri

May 10, 2023

Owner

flavorjones commented May 10, 2023

These classes require Nokogiri v1.14 in order to work properly.

flavorjones added 2 commits

May 10, 2023 10:24


fix: don't define HTML5 doc and frag classes when not supported

730c135

These classes require Nokogiri v1.14 in order to work properly.


doc: better exception when HTML5 functionality isn't supported

d2744d4

flavorjones force-pushed the flavorjones-test-with-old-nokogiri branch from 311aecd to d2744d4 Compare

May 10, 2023 14:25

flavorjones merged commit f874431 into main

flavorjones deleted the flavorjones-test-with-old-nokogiri branch

May 10, 2023 14:33

spyderdfx commented May 10, 2023

Hey.
There is also Loofah::HTML4::Document which uses Nokogiri::HTML4::Document. But it doesn't exist in nokogiri < 1.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment