Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule: libglnx 2024-04-20 #5799

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smcv
Copy link
Collaborator

@smcv smcv commented May 2, 2024

* Fix function detection when using -Werror=return-type
  (Resolves: flatpak#5778)
* Add a fallback definition for G_PID_FORMAT
* Avoid warnings for g_steal_fd() when targeting older GLib

Signed-off-by: Simon McVittie <[email protected]>
@smcv smcv marked this pull request as draft May 2, 2024 13:15
@smcv
Copy link
Collaborator Author

smcv commented May 2, 2024

Actually, don't land this right now - I'm preparing an alternative PR which converts libglnx into a git subtree to avoid the problems with submodules that @GeorgesStavracas encountered while releasing 1.14.7, and having this MR side-by-side with its git subtree equivalent will make a useful comparison.

@smcv
Copy link
Collaborator Author

smcv commented May 2, 2024

Actually, don't land this right now - I'm preparing an alternative PR which converts libglnx into a git subtree to avoid the problems with submodules that @GeorgesStavracas encountered while releasing 1.14.7, and having this MR side-by-side with its git subtree equivalent will make a useful comparison.

After doing #5800 (a one-time big merge to replace the submodule with a subtree), the subtree equivalent of this PR would be similar to smcv#1. I personally think that's a lot nicer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant