Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Fix a misleading comment #5779

Merged
merged 1 commit into from
Apr 18, 2024
Merged

tests: Fix a misleading comment #5779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tests: Fix a misleading comment 
Arguably bwrap should exit with status 127 if it can't find the
executable, but right now it exits 1, so we accept any nonzero status.
The implementation was correct, but the comment was wrong.

Fixes: 84984e4 "test-run: Add a reproducer for CVE-2024-32462"
Signed-off-by: Simon McVittie <[email protected]>
  • Loading branch information
@smcv
smcv committed Apr 18, 2024
commit 2bb91c8652e5f2367ab6ab42a7a6215b6493ddc5
2 changes: 1 addition & 1 deletion tests/test-run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ assert_file_has_content hello_out '^Hello world, from a sandbox$'
ok "hello"

# This should try and fail to run e.g. /usr/bin/--tmpfs, which will
# exit with status 127 because there is no such executable.
# exit with a nonzero status because there is no such executable.
# It should not pass "--tmpfs /blah hello.sh" as bwrap options.
exit_status=0
run --command=--tmpfs org.test.Hello /blah hello.sh >&2 || exit_status=$?
Expand Down
Loading