Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devcontainer for codespace development #5767

Merged
merged 1 commit into from
May 1, 2024

Conversation

eeejay
Copy link
Contributor

@eeejay eeejay commented Apr 8, 2024

This is useful for easy development on a live system without compromising the developer's /usr.

@eeejay
Copy link
Contributor Author

eeejay commented Apr 8, 2024

Just realized that bwrap won't work because we don't have kernel.unprivileged_userns_clone .
Investigating if we will need to use setuid mode here..

@eeejay eeejay marked this pull request as draft April 8, 2024 19:40
@eeejay
Copy link
Contributor Author

eeejay commented Apr 8, 2024

OK, "runArgs": ["--privileged"] did the trick.

@eeejay eeejay marked this pull request as ready for review April 8, 2024 20:01
@TingPing
Copy link
Member

TingPing commented Apr 8, 2024

I'm not against it but I think minimal effort will be made to maintain it.

@GeorgesStavracas
Copy link
Member

I don't know what a devcontainer nor codespace are, so I must say, it would be appreciated if you could write a more detailed commit message explaining where this is expected to be used, and how, by whom, under which circumstances.

This allows a developer to quickly open a remote container set up for
Flatpak development by using GitHub's Codespaces feature.
@eeejay
Copy link
Contributor Author

eeejay commented Apr 30, 2024

I added a better commit message. If you click on the "Code" dropdown button in the main flatpak repo page there is a "Codespaces" tab. If you proceed to create a codespace a new tab will open with VSCode loaded into it with a full dev environment. The .devcontainer file I provided installs all the prerequisites and configures the container for Flatpak development.

One of the nice things about this is that it allows you to set up a VM very quickly so you can install Flatpak to /usr and mess around to your heart's content.

@TingPing TingPing merged commit ffa0f14 into flatpak:main May 1, 2024
9 checks passed
@GeorgesStavracas
Copy link
Member

Thanks for improving the commit message as requested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants