run: Don't inherit LD_PRELOAD/LD_AUDIT from the host

[TingPing]

I don't think this env var makes much sense to pass into the sandbox for similar reasons to LD_LIBRARY_PATH. Libraries from the host just aren't relevant.

Users can still pass --env=LD_PRELOAD=/foo to use this functionality.

[Erick555]

There is a comment below that says:

If updating this list, also update the list in flatpak-run.xml.

It's easy to miss since it's in the middle of the list so perhaps should be moved on top.

[smcv]

For completeness, we might want to do the same for LD_AUDIT, which is like LD_PRELOAD but more so.

[smcv]

As @Erick555 said, please update the documentation to match. Other than that, this LGTM.

Adding LD_AUDIT can be part of this change, or it can be separate.

I would say that changing the organization/layout of this list and its comments as @Erick555 suggested is out-of-scope for this particular PR (but might be a good idea to do separately).

[smcv]

Users can still pass --env=LD_PRELOAD=/foo to use this functionality.

Did you test this? It would be good to know for sure that it's true.

[TingPing]

Did you test this? It would be good to know for sure that it's true.

Yes I confirmed it works.

[smcv]

run: Don't inherhit…

Typo: should say inherit

[smcv]

LGTM, other than the typo

[TingPing]

Hmm, I actually hit some failures:

error: Can't open generated ld.so.cache

So I'll check this out later.

[TingPing]

This happens on main, so it must be a badly configured build, but I'll verify everything is good before merging.

[smcv]

I'll verify everything is good before merging

Not merging this right now because it's still marked as draft, but the change looks good, so please re-test.