Fix missing declaration for g_fdwalk_set_cloexec() with GLib 2.80.x #5737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failures are because we're consistently getting |
|
LGTM |
With older GLib, it's provided by libglnx, but with newer GLib, we need to include the correct header. Fixes: 7b1cd20 "Replace flatpak_close_fds_workaround() with g_fdwalk_set_cloexec()" Signed-off-by: Simon McVittie <[email protected]>
GeorgesStavracas
approved these changes
Mar 20, 2024
gnomesysadmins
pushed a commit
to GNOME/libglnx
that referenced
this pull request
May 13, 2024
When compiling with GLib older than 2.80.x, we provide a compatibility backport of g_closefrom() and g_fdwalk_set_cloexec(), but when compiling with newer GLib, we rely on GLib to provide those. The intended scope of libglnx (Linux only) is narrower than the scope of `<glib-unix.h>` (any Unix platform), so we can safely include `<glib-unix.h>` unconditionally. This provides least-astonishment by having `#include <libglnx.h>` with newer GLib always provide a superset of the functionality it provides with older GLib. This would have avoided needing flatpak/flatpak#5737. Signed-off-by: Simon McVittie <[email protected]>
gnomesysadmins
pushed a commit
to GNOME/libglnx
that referenced
this pull request
May 13, 2024
When compiling with GLib older than 2.80.x, we provide a compatibility backport of g_closefrom() and g_fdwalk_set_cloexec(), but when compiling with newer GLib, we rely on GLib to provide those. The intended scope of libglnx (Linux only) is narrower than the scope of `<glib-unix.h>` (any Unix platform), so we can safely include `<glib-unix.h>` unconditionally. This provides least-astonishment by having `#include <libglnx.h>` with newer GLib always provide a superset of the functionality it provides with older GLib. This would have avoided needing flatpak/flatpak#5737. Fixes: 6ada39c "backports: Add a backport of g_closefrom(), g_fdwalk_set_cloexec()" Signed-off-by: Simon McVittie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With older GLib, it's provided by libglnx, but with newer GLib, we need to include the correct header.
Fixes: 7b1cd20 "Replace flatpak_close_fds_workaround() with g_fdwalk_set_cloexec()"