app: Improve table ellipsization #5722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the display of ellipsized columns in `flatpak remotes -d` with wide terminals.
These commands no longer need to use flatpak_table_printer_print_full().
chrisawi
force-pushed
the
table-ellipsis
branch
from
16af9a7
to
b2f7e54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having each command call
flatpak_get_window_size(), do it by default inflatpak_table_printer_print(). This fixes the display of ellipsized columns inflatpak remotes -dwith wide terminals.If preferred, I can fix the remotes command instead, but this seemed a better option.