Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory errors in testlibrary and other test code #5691

Merged
merged 10 commits into from
Feb 15, 2024
Merged

Fix memory errors in testlibrary and other test code #5691

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dbe05c1
tests: Fix a double-free when exercising argument parsing
smcv Feb 15, 2024
f291cc6
testlibrary: Don't leak transactions
smcv Feb 15, 2024
8dd4358
testlibrary: Don't leak several installed references
smcv Feb 15, 2024
0d57ef1
testlibrary: Don't leak FlatpakInstance
smcv Feb 15, 2024
96c56e1
testlibrary: Don't leak icon data
smcv Feb 15, 2024
15f1204
testlibrary: Don't leak an array of related refs
smcv Feb 15, 2024
f8270a4
testlibrary: Don't leak strings retrieved from remote
smcv Feb 15, 2024
55b52f0
test_list_remote_related_refs: Don't leak list of subpaths
smcv Feb 15, 2024
3f9d3e0
testlibrary: Don't leak list of subpaths
smcv Feb 15, 2024
9798659
httpcache: Free the GError before exiting
smcv Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
testlibrary: Don't leak several installed references 
Signed-off-by: Simon McVittie <[email protected]>
  • Loading branch information
@smcv
smcv committed Feb 15, 2024
commit 8dd4358dc1374c48558724c88a35042c30b5848d
7 changes: 5 additions & 2 deletions tests/testlibrary.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,7 +1220,7 @@ test_update_installed_ref_if_missing_runtime (void)
G_GNUC_END_IGNORE_DEPRECATIONS
g_assert_no_error (error);
g_assert_true (FLATPAK_IS_INSTALLED_REF (iref));
iref = NULL;
g_clear_object (&iref);

/* Install the Locale extension */
G_GNUC_BEGIN_IGNORE_DEPRECATIONS
Expand All @@ -1234,7 +1234,7 @@ test_update_installed_ref_if_missing_runtime (void)
G_GNUC_END_IGNORE_DEPRECATIONS
g_assert_no_error (error);
g_assert_true (FLATPAK_IS_INSTALLED_REF (iref));
iref = NULL;
g_clear_object (&iref);

updatable_refs = flatpak_installation_list_installed_refs_for_update (inst, NULL, &error);
g_assert_cmpint (updatable_refs->len, ==, 1);
Expand All @@ -1259,6 +1259,7 @@ test_update_installed_ref_if_missing_runtime (void)
iref = flatpak_installation_get_installed_ref (inst, FLATPAK_REF_KIND_RUNTIME, "org.test.Platform", NULL, NULL, NULL, &error);
g_assert_nonnull (iref);
g_assert_no_error (error);
g_clear_object (&iref);
}

static void
Expand Down Expand Up @@ -4486,12 +4487,14 @@ test_overrides (void)
G_GNUC_END_IGNORE_DEPRECATIONS
g_assert_no_error (error);
g_assert_nonnull (ref);
g_clear_object (&ref);

G_GNUC_BEGIN_IGNORE_DEPRECATIONS
ref = flatpak_installation_install (inst, repo_name, FLATPAK_REF_KIND_RUNTIME, "org.test.Platform", NULL, "master", NULL, NULL, NULL, &error);
G_GNUC_END_IGNORE_DEPRECATIONS
g_assert_no_error (error);
g_assert_nonnull (ref);
g_clear_object (&ref);

{
TESTS_SCOPED_STDOUT_TO_STDERR;
Expand Down