Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flatpak-run.xml - Fix ambiguity due to lack of punctuation & capitalization #5677

Merged
merged 2 commits into from Feb 3, 2024

Conversation

illtellyoulater
Copy link
Contributor

@illtellyoulater illtellyoulater commented Feb 1, 2024

Do not accept this PR if you enjoy reading a sentence like this: arguments between '@@ u' and '@@' are considered uris, and any file: uris are exported.

Do not accept this PR if you enjoy this sentence: Arguments between '@@U' and '@@' are considered uris, and any file: uris are exported.
@TingPing
Copy link
Member

TingPing commented Feb 2, 2024

Are you trying to format the characters, because docbook has syntax for that, ` is just a weird quote?

@illtellyoulater
Copy link
Contributor Author

@TingPing no I didn't intend to format the characters, I just wanted to surround words with some punctuation but as I saw that quotes or double quotes were used a bit inconsistently across the documentation I preferred to remain neutral and ended up using ` :) but of course replace them with whatever you think is more appropriate. Thank you!

@TingPing
Copy link
Member

TingPing commented Feb 2, 2024

I'd prefer " personally.

@illtellyoulater illtellyoulater marked this pull request as draft February 2, 2024 19:00
@illtellyoulater illtellyoulater marked this pull request as ready for review February 2, 2024 19:10
@TingPing TingPing merged commit 897c46f into flatpak:main Feb 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants