flatpak-run-wayland: Change security-context sandbox engine name #5558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm very tempted to merge this even ahead of the spec saying "should be rDNS", because as far as I'm aware, Flatpak is the only implementation of the client (i.e. sandbox engine) side right now, and we know that |
|
Seems like you can press the trigger. |
This PR is still draft. It can't be merged until un-drafted and approved. |
smcv
approved these changes
Oct 24, 2023
To align with work in D-Bus, the security-context's sandbox engine names are now supposed to follow the reverse-DNS style. This change should be fine because there has not been a release of flatpak with security-context support, yet.
smcv
force-pushed
the
wip/security-context-reverse-dns
branch
from
d04102f
to
8802d72
Compare
|
The wayland-protocols side got merged. This is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To align with work in D-Bus, the security-context's sandbox engine names are now supposed to follow the reverse-DNS style.
This change should be fine because there has not been a release of flatpak with security-context support, yet.
Related: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/253
We need to either merge both MRs or none of them.