Use glnx_opendirat() and glnx_opendirat_with_errno() where possible
#5527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doraskayo
changed the title
glnx_opendirat and glnx_opendirat_with_errno where possibleglnx_opendirat() and glnx_opendirat_with_errno() where possible
doraskayo
force-pushed
the
glnx-opendirat
branch
2 times, most recently
from
af31841
to
9a4b615
Compare
Doing so adds the following flags to the openat() call: O_RDONLY | O_NONBLOCK | O_NOCTTY And removes the following flag: O_PATH Also let libglnx handle the error message formatting.
Also print error message in case the operation fails. No change in behavior apart from printing the error message.
No change in behavior.
doraskayo
force-pushed
the
glnx-opendirat
branch
from
9a4b615
to
be42574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5510 (comment). Only build-tested.
CC: @smcv
instance: Use glnx_opendirat() where possible
Doing so adds the following flags to the openat() call:
O_RDONLY | O_NONBLOCK | O_NOCTTY
And removes the following flag: O_PATH
Also let libglnx handle the error message formatting.
portal: Use glnx_opendirat()
Also print error message in case the operation fails.
No change in behavior apart from printing the error message.
revokefs: Use glnx_opendirat_with_errno()
No change in behavior.