dir: Set up the apply_extra sandbox like flatpak-run --sandbox #5466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is all wrong, as per: |
|
Well, the splitting out for clarity may be nice, but the make_sandbox() part is useless. |
|
Should have an actual comment about the NO_PROC part though. |
|
See cd21428 for why NO_PROC was added. |
|
I'll add the comment about The only semantic difference then is the e: that's actually no semantic difference either... |
swick
force-pushed
the
mr/apply-extra-data-sandbox
branch
from
d95987e
to
fdd0bb5
Compare
|
Should be good now. |
They are the same as `flatpak run --sandbox` with two exceptions:
* `FLATPAK_RUN_FLAG_MULTIARCH` might be required so we just add it
always
* `FLATPAK_RUN_FLAG_NO_PROC` is added to prevent sandbox escapes via
`/proc/self/exe`
Signed-off-by: Sebastian Wick <[email protected]>
alexlarsson
force-pushed
the
mr/apply-extra-data-sandbox
branch
from
fdd0bb5
to
af58d8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same run flags and highlight which ones are specific to apply_extra. Also mark the flatpak context as sandboxed.