RevokeFS demo fixes #5458
Open
RevokeFS demo fixes #5458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some `g_print*` messages were missing newlines and `perror` already appends `: ` to the provided message.
If the write end of the socket is marked to close on exec, then it will also be closed in the FUSE process and it can't actually do anything that involves the backend. Instead, add a setup function for the backend that closes the write end of the socket after forking.
Create a pipe and use the `--exit-with-fd` option to make the backend exit when the demo process completes.
Without this, the spawned FUSE process doesn't exit.
This is particularly useful to run the FUSE process with `-o debug` and see exactly how the FUSE requests are being processed.
|
Seems to break tests/[email protected] in one of the CI tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The revokefs demo was very helpful when debugging #5452, but I needed to hack in a few things to get it to do what I wanted.