Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testlibrary: Initialize autofree variable to silence a compiler warning #5366

Merged
merged 1 commit into from Mar 30, 2023

Conversation

smcv
Copy link
Collaborator

@smcv smcv commented Mar 23, 2023

As with commit 43085c0 "dir: Consistently initialize g_autofree variables", this is currently harmless because we never actually early-return or goto out of the region between declaration and initialization, but some compiler versions log a warning here anyway.

As with commit 43085c0 "dir: Consistently initialize g_autofree
variables", this is currently harmless because we never actually
early-return or goto out of the region between declaration and
initialization, but some compiler versions log a warning here anyway.

Signed-off-by: Simon McVittie <[email protected]>
@github-advanced-security
Copy link

You have successfully added a new shellcheck configuration differential-shellcheck. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@evelikov
Copy link

Don't know what the review process is, so fwiw:

Reviewed-by: Emil Velikov <[email protected]>

Side note: it might be beneficial to add bleeding edge distro into the mix (Arch or any other) which ships newer gcc/clang into the build matrix. Then one can also add -D werror=true to ensure new warnings don't silently creep-in.

Mind you this idea should be a separate follow-up PR, assuming maintainers see value in it in the first place.

@alexlarsson
Copy link
Member

lgtm

@alexlarsson alexlarsson merged commit cffc3ae into flatpak:main Mar 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants