Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: show information about extra-data in the CLI #4969

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rmnscnce
Copy link
Contributor

@rmnscnce rmnscnce commented Jun 27, 2022

[This PR is will fix #4968]

Before:
image

After:
image


TODOs:

  • Handle multiple extra-data properly
  • Fix any build issues on Flatpak CI

@mwleeds
Copy link
Collaborator

mwleeds commented Jun 29, 2022

The extra-data nature of something is not strictly a permission, so I'm not sure it makes sense in the table of permissions.

Similarly, the "tags" item in the table (which we already have before this branch) is not a permission. According to flatpak-metadata(5): "Tags to include in AppStream XML. Typical values in use on Flathub include beta, stable, proprietary and upstream-maintained."

That said, I guess downloading from an external URL is, in a broad sense, a permission being granted, so maybe it's fine in the same table? Adding another table might clutter things too much.

@rmnscnce
Copy link
Contributor Author

rmnscnce commented Jun 29, 2022

That said, I guess downloading from an external URL is, in a broad sense, a permission being granted, so maybe it's fine in the same table? Adding another table might clutter things too much.

Yeah, I was actually thinking about how this could adversely effect the UI of the CLI (since extra-data is not really a permission) but I think ultimately we should let users know of the extra data. Should the extra data part be integrated into the download progress UI instead?

@rmnscnce rmnscnce closed this Jun 29, 2022
@rmnscnce
Copy link
Contributor Author

Oops, didn't know that Ctrl+Enter closes the PR with a comment on GitHub. Sorry.

@rmnscnce rmnscnce reopened this Jun 29, 2022
@mwleeds
Copy link
Collaborator

mwleeds commented Jun 29, 2022

That said, I guess downloading from an external URL is, in a broad sense, a permission being granted, so maybe it's fine in the same table? Adding another table might clutter things too much.

Yeah, I was actually thinking about how this could adversely effect the UI of the CLI (since extra-data is not really a permission) but I think ultimately we should let users know of the extra data. Should the extra data part be integrated into the download progress UI instead?

Probably not because by the time there's a progress indicator it would be too late to stop the operation if you decided not to trust the extra-data source (at least, you couldn't stop the HTTP requests that already went out).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants