Disable fancy output under G_MESSAGES_DEBUG and cache result #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just as we already call flatpak_disable_fancy_output() in flatpak_option_context_parse() in case verbose output is enabled via CLI options, disable fancy output in case verbose output was enabled via the G_MESSAGES_DEBUG env var. Without this change, the result of doing e.g. $ G_MESSAGES_DEBUG=OSTree flatpak install ... is pretty useless and ugly, when the output isn't being redirected to a file, since the debug messages are overwritten when we redraw to show progress updates. This makes the output of "flatpak list" a bit ugly when G_MESSAGES_DEBUG is set, but it seems like a small price to pay.
There might be performance issues with doing this many times, so cache the result.
smcv
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.