flatpak-context: Properly flatten filesystem permissions #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps worth making the commit message a bit clearer that this is not granting anyone extra permissions (so not a security issue), just a display issue? Maybe something like
|
|
LGTM other than that. |
When generating flattened permissions (i.e. for --show-permissions or for the /.flatpak-info file) we're currently flattening the permissions i.e. don't show things that would only affect layering the permissions). However, the code doesn't currently do this for the filesystem key, so implement that. This means we only display the permissions that are in effect, and don't display "negative" permissions like !host which are not meaningful in this context.
alexlarsson
force-pushed
the
flatten-filesystem-permissions
branch
from
868ea3b
to
0892c4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating flattened permissions (i.e. for --show-permissions or
for the /.flatpak-info file) we're currently flattening the permissions
(i.e. don't show things that would only affect layering the permissions).
However, the code doesn't currently do this for the filesystem key, so
implement that.