Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run: Fix session-bus and a11y-bus args being incorrect #4630

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

TingPing
Copy link
Member

@TingPing TingPing commented Dec 22, 2021

This would incorrectly overwrite the a11y-bus option and not set the default session-bus options.

This change has a security implication that --sandbox will now disable session-bus access.

This would incorrectly overwrite the a11y-bus option and not set the default
session-bus options.
Copy link
Collaborator

@smcv smcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and we probably want this on 1.12.x too.

@TingPing TingPing merged commit 17b05b0 into master Jan 4, 2022
@TingPing TingPing deleted the pgriffis/fix-bus-args branch January 4, 2022 19:02
@TingPing
Copy link
Member Author

TingPing commented Jan 4, 2022

Backported to 1.12.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants