-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portal install #3322
base: main
Are you sure you want to change the base?
Portal install #3322
Conversation
fee4ad2
to
f7332df
Compare
This adds an Install method to the update monitor portal and allows to install app or runtime extensions. This uses two new permissions in the flatpak table: install-app-extensions and install-extensions. This commit also changes the default permissions. If no permissions are stored, we default to YES for self-updates and app extensions, and to ASK for runtime extensions. Fixes: flatpak#3317
f7332df
to
5280ca3
Compare
Somewhat tested now, with code in flatpak/libportal#11 |
extension_of = g_key_file_get_string (keyfile, | ||
FLATPAK_METADATA_GROUP_EXTENSION_OF, | ||
FLATPAK_METADATA_KEY_REF, | ||
NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a great check. Many runtime extensions will be marked as extensions of the fd.o runtime, but the app might be using a derivate of it that still references the same extension point. I think we instead need to load the app/runtime metadata file and call flatpak_list_extensions() on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
runtime it is using. | ||
If that is not the case, the operation will fail with | ||
the error org.freedesktop.DBus.Error.NotSupported | ||
and the installation has to be done with the system tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the installation will have to be done"...
@ref: ref to install | ||
@options: Vardict with optional further information | ||
|
||
Asks to install one or more Flatpak refs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The arguments list it as "ref" and it's a single string. Is there an example on how to specify multiple refs using a single argument?
What's the status of it? Seems like the Steam flatpak could benefit from this a lot. |
I suppose now that enough time has passed, Steam flatpak is not going to benefit from this anymore.... |
Kodi would massively benefit from this, as it would be nice to manage the installed flatpak addons from inside kodi. So for e.g. via controller or remote, especially when your setup directly boots into kodi as a DE. |
This would massively benefit lutris, but thats only because Flatpak wont install lutris dependencies.... (because lutris is in flathub beta and flatpak doesn't like installing extensions across repos) |
This would benefit Bottles as well, since it doesn't automatically pull in some extensions, such as Gamescope, and the Flatpak CLI isn't very user-friendly. |
Can also benefit lutris/steam and any other app that use/will use this extensions. |
Add an Install method to the updates portal.
Needs testing.