Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal install #3322

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

matthiasclasen
Copy link
Collaborator

Add an Install method to the updates portal.

Needs testing.

@matthiasclasen matthiasclasen force-pushed the portal-install branch 6 times, most recently from fee4ad2 to f7332df Compare December 19, 2019 18:41
Matthias Clasen added 2 commits December 19, 2019 15:58
This adds an Install method to the update monitor
portal and allows to install app or runtime
extensions.

This uses two new permissions in the flatpak table:
install-app-extensions and install-extensions.

This commit also changes the default permissions.
If no permissions are stored, we default to YES
for self-updates and app extensions, and to ASK
for runtime extensions.

Fixes: flatpak#3317
@matthiasclasen
Copy link
Collaborator Author

Somewhat tested now, with code in flatpak/libportal#11

extension_of = g_key_file_get_string (keyfile,
FLATPAK_METADATA_GROUP_EXTENSION_OF,
FLATPAK_METADATA_KEY_REF,
NULL);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a great check. Many runtime extensions will be marked as extensions of the fd.o runtime, but the app might be using a derivate of it that still references the same extension point. I think we instead need to load the app/runtime metadata file and call flatpak_list_extensions() on that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

runtime it is using.
If that is not the case, the operation will fail with
the error org.freedesktop.DBus.Error.NotSupported
and the installation has to be done with the system tools.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the installation will have to be done"...

@ref: ref to install
@options: Vardict with optional further information

Asks to install one or more Flatpak refs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arguments list it as "ref" and it's a single string. Is there an example on how to specify multiple refs using a single argument?

@gasinvein
Copy link
Member

What's the status of it? Seems like the Steam flatpak could benefit from this a lot.

@nanonyme
Copy link
Contributor

I suppose now that enough time has passed, Steam flatpak is not going to benefit from this anymore....

@razzeee
Copy link

razzeee commented Jan 11, 2022

Kodi would massively benefit from this, as it would be nice to manage the installed flatpak addons from inside kodi. So for e.g. via controller or remote, especially when your setup directly boots into kodi as a DE.

@A6GibKm
Copy link

A6GibKm commented Mar 21, 2022

This would massively benefit lutris, but thats only because Flatpak wont install lutris dependencies.... (because lutris is in flathub beta and flatpak doesn't like installing extensions across repos)

@orowith2os
Copy link

orowith2os commented Sep 17, 2022

This would benefit Bottles as well, since it doesn't automatically pull in some extensions, such as Gamescope, and the Flatpak CLI isn't very user-friendly.

@soredake
Copy link

Can also benefit lutris/steam and any other app that use/will use this extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

9 participants